Ignore cached wp_theme_has_theme_json when WP_DEBUG is enabled
#45882
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmtr
added
[Type] Performance
|
|
felixarntz
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
LGTM in terms of just fixing the problem here, although we may want to consider a more holistic situation.
How about introducing a function like wp_theme_debug_enabled() which returns this as a boolean, which we can use in any places where we use caching around theme-powered code? At a minimum the function could be the WP_DEBUG check we've been starting to use, but potentially it should go further with e.g. additionally having a filter to control it so that it can be dynamically set or modified at runtime.
…theme-json-ignore-cache-wp-debug
mmtr
deleted the
update/wp-theme-has-theme-json-ignore-cache-wp-debug
branch
mmtr
restored the
update/wp-theme-has-theme-json-ignore-cache-wp-debug
branch
mmtr
deleted the
update/wp-theme-has-theme-json-ignore-cache-wp-debug
branch
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up #45543
What?
This PR updates the
wp_theme_has_theme_jsonso it ignores the cache whenWP_DEBUGis enabled.Why?
theme.jsonfile).gutenberg_get_global_stylesheetto useWP_Object_Cache#45679 and AddWP_Object_Cacheto thegutenberg_get_global_settingsmethod #45372).Testing Instructions
TBD